Enable Telemetry by default #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcotc should we make sure to merge DataDog/system-tests#1048, validate all test passes on our end and then merge this PR? |
|
@GustavoCaso merged the system-tests in question, running it again now. |
|
FYI the tests showing up as pending are fixed in #2772 so they're OK to ignore |
|
We've had potential flaky specs related to enabling telemetry by default. Is is still the case? |
|
@marcotc I don't see the |
|
@GustavoCaso They have arrived! |
GustavoCaso
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All system-tests are now passing and fixes have been merged into
masteralready to address all inconsistencies.Telemetry is ready to go!
#2761 will ensure
dd-trace-rbtriggers all telemetry tests on each commit. All tests are already passing in the system-tests repository itself. It's just a matter of making sure they keep passing.