Add workaround for pending gitlab benchmark jobs #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR adds a workaround for the GitLab benchmark jobs configuration that was causing them to show up on GitHub as "Pending" and never completing for every PR. **Motivation**: Currently the jobs don't run on every PR so this fixes the "Pending" issue. Hopefully soon we'll start running the benchmarks on every PR and so we'll be able to remove this workaround. **Additional Notes**: Thanks @ddyurchenko for the help setting this so far. **How to test the change?**: Verify that you no longer see "Pending" jobs on the GitHub CI status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR adds a workaround for the GitLab benchmark jobs configuration that was causing them to show up on GitHub as "Pending" and never completing for every PR.
Motivation:
Currently the jobs don't run on every PR so this fixes the "Pending" issue.
Hopefully soon we'll start running the benchmarks on every PR and so we'll be able to remove this workaround.
Additional Notes:
Thanks @ddyurchenko for the help setting this so far.
How to test the change?:
Verify that you no longer see "Pending" jobs on the GitHub CI status.