Build with Rust 1.52 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate is a dependency of `system-deps` which is a pretty foundational library. In my case, we use the `glib` and gtk-rs bindings which transitively depend on this. Not everyone can move at upstream Rust speed. While there are improvements, there are sometimes regressions too (thankfully, not many, but still). In this case, I hope you'd agree that while the new "or pattern" feature is *nice* it's far from a must have. (Unlike e.g. const generics or so)
cgwalters
force-pushed
the
build-with-older-rust
branch
from
ffb1419
to
e24b605
Compare
Jake-Shadle
approved these changes
Aug 5, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate is a dependency of
system-depswhich is a prettyfoundational library. In my case, we use the
gliband gtk-rs bindingswhich transitively depend on this.
Not everyone can move at upstream Rust speed. While there are improvements,
there are sometimes regressions too (thankfully, not many, but still).
In this case, I hope you'd agree that while the new "or pattern" feature
is nice it's far from a must have. (Unlike e.g. const generics or so)