Replace deprecated lint and add msrv in clippy.toml #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cgwalters
reviewed
Aug 5, 2021
| @@ -13,7 +13,7 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions-rs/toolchain@v1 | |||
| with: | |||
| toolchain: "1.52.0" | |||
| toolchain: stable | |||
There was a problem hiding this comment.
Wait but why are you changing this? I think pinning on 1.52 is useful for e.g. #31
There was a problem hiding this comment.
I could revert it, but I will have to re add the deprecated lints. Would it be more efficient to test compilation to rust 1.52 than forcing Clippy to be at 1.52 since Clippy as an option for msrv?
Jake-Shadle
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Remove a deprecated option and add msrv to clippy.toml to help developer not see breaking Clippy change.