Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Tests: Fix inserting media elements #7481

Closed
spacedmonkey opened this issue May 11, 2021 · 2 comments · Fixed by #12439
Closed

E2E Tests: Fix inserting media elements #7481

spacedmonkey opened this issue May 11, 2021 · 2 comments · Fixed by #12439
Labels
P3 Nice to have Package: E2E Tests /packages/e2e-tests Type: Enhancement New feature or improvement of an existing feature Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@spacedmonkey
Copy link
Contributor

spacedmonkey commented May 11, 2021 •
edited by barklund
Loading

Feature Description

A number of e2e tests inserting media elements are unstable. This is probably due to the moveable-overlay on top of the media elements, that cause clicks to sometimes be ignored, sometimes work correctly.

These tests are skipped for that reason and need fixing:

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@spacedmonkey spacedmonkey added Type: Enhancement New feature or improvement of an existing feature Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP & Infra Package: E2E Tests /packages/e2e-tests labels May 11, 2021
@swissspidy swissspidy changed the title Unskip Inserting 3P Media coverr video e2e test E2E Tests: Unskip Coverr test May 11, 2021
@swissspidy swissspidy added the P3 Nice to have label May 27, 2021
@barklund barklund mentioned this issue Jul 30, 2021
Merged
8 tasks
barklund pushed a commit that referenced this issue Jul 30, 2021
Skipped some unstable tests - see #7481 for details
a3a67b5
@barklund barklund changed the title E2E Tests: Unskip Coverr test E2E Tests: Fix inserting media elements Jul 30, 2021
@barklund barklund added P0 Critical, drop everything Pod: Prometheus and removed P3 Nice to have labels Jul 30, 2021
@barklund barklund mentioned this issue Aug 1, 2021
Closed
9 tasks
@swissspidy swissspidy mentioned this issue Aug 2, 2021
Merged
9 tasks
@barklund barklund added P1 High priority, must do soon and removed P0 Critical, drop everything labels Aug 4, 2021
@swissspidy swissspidy added P2 Should do soon P3 Nice to have and removed P1 High priority, must do soon Pod: Prometheus P2 Should do soon labels Aug 11, 2021
barklund pushed a commit that referenced this issue Aug 12, 2021
@swissspidy @miina
Update tab rendering logic and interaction (#8335)
74275d5 
* Kept focused tab as state, only activate on enter/space/click

* Only render current tab contents in inspector

* Rendered only current tab content in library

* Updated logic around when to render which pane (mostly irrelevant now)

* Fix the case of missing tab refs to fix storybook

* Removed irrelevant variable

* Removed irrelevant test

* Fixed karma test for library tabs keyboard nav

* Made sure that enter/space only activates current tab if on focused on a tab

* Updated media provider tabs to act correctly aria-wise

* Added missing new files

* Trying to fix failing unit tests

* Skipped some unstable tests - see #7481 for details

* Unskipped tests now that moveable is no longer lazyloaded

* Re-skipped a single test, that is clearly still flaky

* Some test fixes.

Co-authored-by: Pascal Birchler <pascalb@google.com>
Co-authored-by: Miina Sikk <miina.sikk@gmail.com>
@spacedmonkey
Copy link
Contributor Author

@barklund as you updated this ticket and seem to have more context. Can you update more details why you think this issue has started and any possible solutions.

@swissspidy
Copy link
Collaborator

FWIW, when Morten noticed this, it was a long time after you've created this ticket, so any flakiness was already there before his work on #8335.

IIRC one potential culprit was the Moveable integration in the library.

cc @miina

swissspidy added a commit that referenced this issue Oct 7, 2022
@swissspidy
Re-enable some Media3P tests
cba8f26 
See #7481
@swissspidy swissspidy mentioned this issue Oct 18, 2022
Merged
8 tasks
swissspidy added a commit that referenced this issue Oct 21, 2022
@swissspidy @googleforcreators-bot
@dependabot @spacedmonkey @timarney
Improve E2E Tests & Stability (#12439)
5756117 
* Improve taxonomies e2e tests

* Add `jest.retryTimes` to every spec file

* Further improve taxonomy tests

* Improve hotlinking tests

* Wrap all `page.waitForNavigation()` calls in `Promise.all`

* Deactivate importer again after install

* Remove `:focus-visible` polyfill

Browser support has much improved this year, with Safari adding support in version 15.4 in March 2022.

Safari 15.4 ships with the iOS and iPadOS 15.4 and macOS 12.3.

* Dynamically import `@mediapipe/selfie_segmentation`

Fixes #12383

* Re-enable admin menu e2e tests

* Re-enable shopify test

See #11994

* Re-enable WooCommerce test

See #11976

* Re-enable story bg audio test

See #12025

* Re-enable font check test

See #11361

* Re-enable story deletion test

See #11362

* Re-enable story saving failing test

See #11992

* Re-enable quick edit test

* Improve status check and re-enable status check tests

See #11991

* Re-enable CORS check test

See #11981

* Re-enable widget tests

See #11990
See #6879

* Re-enable font check metrics test

See #11978

* Make publishPost util more robust

* Re-enable archive page tests

See #9636
See #11990

* Re-enable block widget test

See #11931

* Re-enable pending stories test

See #11993

* Re-enable Site Kit analytics test

See #9985

* Re-enable Web Stories block tests

See #11975
See #6237

* Remove redundant test

See #12023

* Re-enable shopping product test

See #11989

* Re-enable dashboard keyboard navigation test

See #11930

* Re-enable publisher logo test

See #9152

* Add types for `expect-puppeteer` to improve IDE assistance

* Re-enable checklist test

See #11977

* Re-enable some Media3P tests

See #7481

* Remove ext from import

* Remove outdated export

* Re-enable media library test

See #7107

* Avoid using `undefined` as background image

* Re-enable webm video tests

See #11959

* Re-enable media insertion test

See #7107

* Re-enable mov insertion test

See #8232

* Re-enable pre-publish modal poster test

See #7107

* Re-enable pre-publish modal poster test w/ contributor

See #7107

* Remove useless telemetry banner test

See #9619

* Do not prefetch colorthief chunk

* Remove some debug cruft

* Do not use `toMatchElement` return value

* Delete also cropped media in cleanup

* Improve addTextElement util

* Improve previewStory util

* Use sync fs api

* Remove useless check

* Do not use `toMatchElement` return value

* Fix draft-js-export-html dependency entry

* Add types for `expect-puppeteer` to improve IDE assistance

* Do not fail fast for now

* Update browserslist db (#12446)

* Add missing await

* Update to Puppeteer v18

* Improve custom font util

* Bump eslint-plugin-jest from 27.0.4 to 27.1.1 (#12458)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-json from 4.1.0 to 5.0.0 (#12457)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump semver from 7.3.7 to 7.3.8 (#12456)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Disallow closing story takeover dialog (#12440)

* Bump eslint from 8.24.0 to 8.25.0 (#12455)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-node-resolve from 14.1.0 to 15.0.0 (#12454)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-url from 7.0.0 to 8.0.0 (#12452)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump css-minimizer-webpack-plugin from 4.2.0 to 4.2.1 (#12453)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @typescript-eslint/parser from 5.39.0 to 5.40.0 (#12451)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sirbrillig/phpcs-variable-analysis from 2.11.8 to 2.11.9 (#12450)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github/codeql-action from 2.1.26 to 2.1.27 (#12448)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 3.0.2 to 3.1.0 (#12449)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improve story locking dialog wording and layout (#12447)

Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>

* Run tests against WordPress 6.1 RC (#12412)

* [WIP] CI: Use composite actions (#12438)

* Composer update

* Add checkout step

* Revert "Add checkout step"

This reverts commit 07ef47b.

* Revert "[WIP] CI: Use composite actions (#12438)"

This reverts commit 6347baf.

* Revert "Composer update"

This reverts commit faab6ba.

* Lint fix

* Code Quality: Use `preloadImage` in `wp-dashboard` (#12466)

* Code Quality: Fix `preloadImage` function signature (#12468)

* Media: Video Segmentation Prototype (#12335)

Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Pascal Birchler <pascalb@google.com>

* Improve widget tests

* Improve publisher logo test

* Remove duplicate entry

* Improve taxonomy test

* Fix workflow

* Fix fail-fast

* Update lock file

* Update dashboard test

* Improve widget tests

* Fix password protected story test

* Improve createNewTerm util

* Try improving `addCategory` util

* Update to Puppeteer v19

* Improve `addTextElement`

* Adjust `previewPage`

* Try patching jest-environment-puppeteer

* Update `previewStory` util

* Improve addTextElement

* Fix patch

* Update patch

* Fix zero width chars

* Remove patch

* Fix publishing flow test

See #11970

* Update `addTextElement`

* Refactor `deleteWidgets`

* Adjust publisher logo test

* Improve web stories block test

Don’t use request interception for block test, fix AMP validation

* Add env var

* Add fix for REST API change in 6.1

See https://make.wordpress.org/core/2022/10/11/miscellaneous-rest-api-improvements-in-wordpress-6-1/

* Wait for dialog to be dismissed

* Adjust author test

* Add hardening

* Update lock file

* Adjust widget test

* Adjust font check test

* Increase retry times

* Retry unit tests with AMP validation

* A few focus-visible fixes

* Fix selfie segmentation lazy load

* More rigorously trash posts between tests

Co-authored-by: Google for Creators Bot <94923726+googleforcreators-bot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Tim Arney <timarney@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Nice to have Package: E2E Tests /packages/e2e-tests Type: Enhancement New feature or improvement of an existing feature Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve E2E Tests & Stability GoogleForCreators/web-stories-wp
3 participants
@spacedmonkey @barklund @swissspidy