Bug: Fix Eyedropper Karma Test #8524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2021 15:25
|
Size Change: +5.23 kB (0%) Total Size: 2.89 MB
ℹ️ View Unchanged
|
barklund
reviewed
Aug 1, 2021
Comment on lines
+55
to
+57
| // Only regestering image click by clicking twice for some reason | ||
| await fixture.events.click(image); | ||
| await fixture.events.click(image); |
There was a problem hiding this comment.
Yeah, this is the issue we've also recorded in #7481 and that we need to fix in a general manner.
| const bgCanvasRect = | ||
| fixture.editor.canvas.framesLayer.frames[0].node.getBoundingClientRect(); | ||
| // Make sure to click on part of bg element not covered by media element previously | ||
| // assed to canvas |
There was a problem hiding this comment.
😂 😂 😂 😂
Suggested change
| // assed to canvas | |
| // added to canvas |
| const bgCanvasRect = | ||
| fixture.editor.canvas.framesLayer.frames[0].node.getBoundingClientRect(); | ||
| // Make sure to click on part of bg element not covered by media element previously | ||
| // assed to canvas |
There was a problem hiding this comment.
😂 😂 😂 😂
Suggested change
| // assed to canvas | |
| // added to canvas |
Comment on lines
64
to
66
| await fixture.events.mouse.click( | ||
| bgCanvasRect.left + 10, | ||
| bgCanvasRect.bottom - 10 |
There was a problem hiding this comment.
We actually have clickOn for that same purpose:
await fixture.events.mouse.clickOn(fixture.editor.canvas.framesLayer.frames[0].node, 10 ,10);
There was a problem hiding this comment.
ooo very cool. thanks for sharing!
maxyinger
commented
Aug 2, 2021
Comment on lines
+85
to
+89
| // await fixture.events.mouse.move( | ||
| // imageOnCanvasRect.right - 2, | ||
| // imageOnCanvasRect.top + 8 | ||
| // ); | ||
| // await fixture.events.sleep(10000); |
There was a problem hiding this comment.
@merapi @barklund if you uncomment this, and run npm run test:karma:edit-story:watch you can see the misalignment issue I mentioned.
Any thoughts on this? seems like an issue with the eyedropper and not the test, but maybe I'm misunderstanding something. Anyway, y'all have more context here. curious to see what you think
There was a problem hiding this comment.
Found it - I can replicate the issue on one of my machines, will fix it today/tomorrow, right now I will work on a general fix for Moveable (double click/dnd issue).
|
The Moveable fix is already merged and the eyedropper fix will be in another PR, so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Karma test for eye dropper is currently failing on main. This fixes the existing karma test up until the point of the eyedropper having a misalignment issue at it's core. once the eyedropper is fixed this karma test should work properly.
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
QA
This PR can be tested by following these steps:
UAT
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #