Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-[IGListIndexSetResult hasChanges] should instead be a readonly property #402

Closed
mdznr opened this issue Jan 10, 2017 · 3 comments
Closed

-[IGListIndexSetResult hasChanges] should instead be a readonly property #402

mdznr opened this issue Jan 10, 2017 · 3 comments
Labels
enhancement starter-task
Milestone
3.0.0

Comments

@mdznr
Copy link

mdznr commented Jan 10, 2017 •
edited
Loading

-[IGListIndexSetResult hasChanges] should instead be a readonly property.

IGListIndexSetResult.h:46 is currently:

- (BOOL)hasChanges;

it should instead be:

@property (nonatomic, assign, readonly) BOOL hasChanges;
@rnystrom
Copy link
Contributor

I'm down with this. Not breaking for ObjC, breaking for Swift tho. But I think it makes more sense as a computed variable for Swift rather than a method. @jessesquires on board?

@jessesquires
Copy link
Contributor

@rnystrom - Sounds good.

We have other breaking changes coming for 3.0.

@jessesquires jessesquires added this to the 3.0.0 milestone Jan 10, 2017
@mdznr
Copy link
Author

mdznr commented Jan 10, 2017

Thanks for the quick response!

@rnystrom rnystrom mentioned this issue Jan 10, 2017
Closed
@zhubofei zhubofei mentioned this issue Jan 28, 2017
Closed
2 tasks
rnystrom pushed a commit that referenced this issue Feb 6, 2017
- (BOOL) hasChanges should be a readonly property
5a558a1 
Summary:
Closed #402

- [x] All tests pass. Demo project builds and runs.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
Closes #453

Differential Revision: D4479611

Pulled By: rnystrom

fbshipit-source-id: 4c93ce30613e45c19478f9f5d0e59eeeb0142766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement starter-task
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

- (BOOL) hasChanges should be a readonly property bofeizhu/IGListKit
3 participants
@rnystrom @mdznr @jessesquires