Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- (BOOL) hasChanges should be a readonly property #453

Closed
wants to merge 3 commits into from

Conversation

zhubofei
Copy link

@zhubofei zhubofei commented Jan 28, 2017

Changes in this pull request

Closed #402

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.

@facebook-github-bot
Copy link
Contributor

@zhubofei updated the pull request - view changes

@zhubofei zhubofei added this to the 3.0.0 milestone Jan 28, 2017
@rnystrom
Copy link
Contributor

@zhubofei crushing it!

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhubofei zhubofei deleted the hasChanges-to-property branch February 2, 2017 17:59
rnystrom pushed a commit that referenced this pull request Feb 6, 2017
Summary:
Closed #402

- [x] All tests pass. Demo project builds and runs.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
Closes #453

Differential Revision: D4479611

Pulled By: rnystrom

fbshipit-source-id: 4c93ce30613e45c19478f9f5d0e59eeeb0142766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-[IGListIndexSetResult hasChanges] should instead be a readonly property
3 participants