-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace NodeState: demo #3591
Trace NodeState: demo #3591
Conversation
c736338
to
058a670
Compare
d4cd333
to
d3fea80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
3591: Trace NodeState: demo r=deepfire a=denisshevchenko This is the first step toward `NodeState` tracing. The `NodeState` represents the current state of the node. So any external application (for example, `cardano-wallet` or `cardano-tracer`) will be able to ask this state (as a `DataPoint`) and use it. Currently, `NodeState` is almost useless, it only demonstrates the changing the state of a node in real-time. This PR introduces `demo-acceptor` as well: a tiny application allowing to ask `DataPoint` from the node. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also squash the first two commits?
cardano-tracer: seq tests, disable some log tests for Windows.
d3fea80
to
6edce0c
Compare
@Jimbo4350 Done, now there are only 2 commits. |
bors merge |
Build succeeded: |
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo 3707: Workbench: make geneses effectively cacheable in CI, by pinning the producing workbench r=deepfire a=deepfire This makes workbench-produced geneses effectively cacheable in CI, by pinning the producing workbench as a new flake input. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
This is the first step toward
NodeState
tracing. TheNodeState
represents the current state of the node. So any external application (for example,cardano-wallet
orcardano-tracer
) will be able to ask this state (as aDataPoint
) and use it.Currently,
NodeState
is almost useless, it only demonstrates the changing the state of a node in real-time.This PR introduces
demo-acceptor
as well: a tiny application allowing to askDataPoint
from the node.