cardano-node-3644: node state ADT expand. #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
force-pushed
the
cardano-node-3644
branch
4 times, most recently
from
28a6f7c
to
f4a1a92
Compare
denisshevchenko
force-pushed
the
cardano-node-3644
branch
3 times, most recently
from
fb7ba7a
to
2ba1f80
Compare
denisshevchenko
force-pushed
the
cardano-node-3644
branch
from
2ba1f80
to
36bbbae
Compare
denisshevchenko
requested review from
deepfire,
jutaro,
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
deepfire
approved these changes
Mar 15, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 15, 2022
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo 3707: Workbench: make geneses effectively cacheable in CI, by pinning the producing workbench r=deepfire a=deepfire This makes workbench-produced geneses effectively cacheable in CI, by pinning the producing workbench as a new flake input. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 15, 2022
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
JaredCorduan
approved these changes
Mar 15, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #3591, we now have a new
DataPointcalledNodeState. An external application (for example,cardano-wallet) can ask for thisDataPointto know the current state of the node.Initially,
NodeStatewas a primitive ADT and contained a very small portion of information. Now it's expanded.Also, this PR moved node's peers info in a separate
DataPoint.The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo