Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if CometLogger experiment is alive #19915

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

EtayLivne
Copy link
Contributor

@EtayLivne EtayLivne commented May 29, 2024

What does this PR do?

A tiny patch to align how the CometLogger class checks if the the underlying Comet Experiment object it holds needs to be reactivated. Solves cases where CometClient suddenly stops being able to log (e.g due to another Experiment instance being created by any other source).

Fixes #19900

PR review


📚 Documentation preview 📚: https://pytorch-lightning--19915.org.readthedocs.build/en/19915/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 29, 2024
@awaelchli awaelchli changed the title CometLogger fix [issue #19900] Check if CometLogger experiment is alive Jun 18, 2024
@awaelchli awaelchli added this to the 2.3.x milestone Jun 18, 2024
@awaelchli awaelchli added the community This PR is from the community label Jun 18, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for including the test @EtayLivne, LGTM!

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53%. Comparing base (c1af4d0) to head (4c1b9ff).
Report is 88 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c1af4d0) and HEAD (4c1b9ff). Click for more details.

HEAD has 444 uploads less than BASE
Flag BASE (c1af4d0) HEAD (4c1b9ff)
python3.10 42 11
cpu 124 21
lightning 78 15
pytest 59 2
python3.8 33 6
lightning_fabric 9 0
gpu 4 2
examples 6 0
app 6 0
tpu 1 0
pytorch2.0 34 11
pytest-full 70 21
python3.11 18 4
pytorch_lightning 27 8
pytorch2.1 18 4
pytorch2.3 9 3
pytorch2.2 9 3
lightning_app 8 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19915      +/-   ##
==========================================
- Coverage      84%      53%     -31%     
==========================================
  Files         426      418       -8     
  Lines       35293    35140     -153     
==========================================
- Hits        29628    18720   -10908     
- Misses       5665    16420   +10755     

@awaelchli awaelchli merged commit 1e83a1b into Lightning-AI:master Jun 18, 2024
93 checks passed
awaelchli pushed a commit that referenced this pull request Jun 27, 2024
Co-authored-by: Etay Livne <etay.livne@mobileye.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community logger: comet pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating A Second Comet Logger Disables The First
2 participants