Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if CometLogger experiment is alive #19915

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Check if CometLogger experiment is alive #19915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6551bd
fix: CometLogger now correctly identifies when to create new Experime…
May 29, 2024
a69dae1
fixed typo
Jun 17, 2024
4c1b9ff
added test to verify that the Experiment object of a CometLogger rese…
Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lightning/pytorch/loggers/comet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def experiment(self) -> Union["Experiment", "ExistingExperiment", "OfflineExperi
self.logger.experiment.some_comet_function()

"""
if self._experiment is not None:
if self._experiment is not None and self._experiment.alive:
return self._experiment

if self._future_experiment_key is not None:
Expand Down
14 changes: 14 additions & 0 deletions tests/tests_pytorch/loggers/test_comet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,20 @@ def test_comet_logger_online(comet_mock):
api.assert_called_once_with("rest")


@mock.patch.dict(os.environ, {})
def test_comet_experiment_resets_if_not_alive(comet_mock):
"""Test that the CometLogger creates a new experiment if the old one is not alive anymore."""
logger = CometLogger()
assert logger._experiment is None
alive_experiment = Mock(alive=True)
logger._experiment = alive_experiment
assert logger.experiment is alive_experiment

unalive_experiment = Mock(alive=False)
logger._experiment = unalive_experiment
assert logger.experiment is not unalive_experiment


@mock.patch.dict(os.environ, {})
def test_comet_logger_no_api_key_given(comet_mock):
"""Test that CometLogger fails to initialize if both api key and save_dir are missing."""
Expand Down
Loading