-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gobo resource handling #1185
Conversation
This comment has been minimized.
This comment has been minimized.
ddaa3a1
to
43c82e5
Compare
43c82e5
to
7c12c16
Compare
This comment has been minimized.
This comment has been minimized.
b517421
to
cb31e57
Compare
if (resource) { | ||
const qlcplusGoboAlias = Object.keys(qlcplusGoboAliases).find( | ||
alias => qlcplusGoboAliases[alias] === resource.key | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we created the reverse map in advance, performance could be increased when exporting a lot of gobo fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is out of scope of this PR. We can surely pick this up in the future when we see performance hits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Resource
class makes some parts of the code much cleaner!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Plugin export diff(Output of test script You can view your uncommitted changes in plugin exports manually by executing: 💤 afx/lmh460z: colorsourceOutputted files not changed.💤 afx/lmh460z: d-lightOutputted files not changed.💤 afx/lmh460z: ecueOutputted files not changed.💤 afx/lmh460z: milluminOutputted files not changed.💤 afx/lmh460z: op-zOutputted files not changed.💤 afx/lmh460z: qlcplus_4.12.1Outputted files not changed.💤 astera/fp1-titan-tube: colorsourceOutputted files not changed.💤 astera/fp1-titan-tube: d-lightOutputted files not changed.💤 astera/fp1-titan-tube: ecueOutputted files not changed.💤 astera/fp1-titan-tube: milluminOutputted files not changed.💤 astera/fp1-titan-tube: op-zOutputted files not changed.💤 astera/fp1-titan-tube: qlcplus_4.12.1Outputted files not changed.💤 ayrton/magicblade-fx: colorsourceOutputted files not changed.💤 ayrton/magicblade-fx: d-lightOutputted files not changed.💤 ayrton/magicblade-fx: ecueOutputted files not changed.💤 ayrton/magicblade-fx: milluminOutputted files not changed.💤 ayrton/magicblade-fx: op-zOutputted files not changed.💤 ayrton/magicblade-fx: qlcplus_4.12.1Outputted files not changed.💤 cameo/auro-spot-400: colorsourceOutputted files not changed.💤 cameo/auro-spot-400: d-lightOutputted files not changed.💤 cameo/auro-spot-400: ecueOutputted files not changed.💤 cameo/auro-spot-400: milluminOutputted files not changed.💤 cameo/auro-spot-400: op-zOutputted files not changed.💤 cameo/auro-spot-400: qlcplus_4.12.1Outputted files not changed.💤 cameo/hydrabeam-300-rgbw: colorsourceOutputted files not changed.💤 cameo/hydrabeam-300-rgbw: d-lightOutputted files not changed.💤 cameo/hydrabeam-300-rgbw: ecueOutputted files not changed.💤 cameo/hydrabeam-300-rgbw: milluminOutputted files not changed.💤 cameo/hydrabeam-300-rgbw: op-zOutputted files not changed.💤 cameo/hydrabeam-300-rgbw: qlcplus_4.12.1Outputted files not changed.💤 flash-professional/led-moving-head-150w: colorsourceOutputted files not changed.💤 flash-professional/led-moving-head-150w: d-lightOutputted files not changed.💤 flash-professional/led-moving-head-150w: ecueOutputted files not changed.💤 flash-professional/led-moving-head-150w: milluminOutputted files not changed.💤 flash-professional/led-moving-head-150w: op-zOutputted files not changed.💤 flash-professional/led-moving-head-150w: qlcplus_4.12.1Outputted files not changed.💤 generic/pan-tilt: colorsourceOutputted files not changed.💤 generic/pan-tilt: d-lightOutputted files not changed.💤 generic/pan-tilt: ecueOutputted files not changed.💤 generic/pan-tilt: milluminOutputted files not changed.💤 generic/pan-tilt: op-zOutputted files not changed.💤 generic/pan-tilt: qlcplus_4.12.1Outputted files not changed.💤 glp/impression-laser: colorsourceOutputted files not changed.💤 glp/impression-laser: d-lightOutputted files not changed.💤 glp/impression-laser: ecueOutputted files not changed.💤 glp/impression-laser: milluminOutputted files not changed.💤 glp/impression-laser: op-zOutputted files not changed.💤 glp/impression-laser: qlcplus_4.12.1Outputted files not changed.💤 glp/knv-arc: colorsourceOutputted files not changed.💤 glp/knv-arc: d-lightOutputted files not changed.💤 glp/knv-arc: ecueOutputted files not changed.💤 glp/knv-arc: milluminOutputted files not changed.💤 glp/knv-arc: op-zOutputted files not changed.💤 glp/knv-arc: qlcplus_4.12.1Outputted files not changed.💤 lixada/mini-moving-head-rgbw: colorsourceOutputted files not changed.💤 lixada/mini-moving-head-rgbw: d-lightOutputted files not changed.💤 lixada/mini-moving-head-rgbw: ecueOutputted files not changed.💤 lixada/mini-moving-head-rgbw: milluminOutputted files not changed.💤 lixada/mini-moving-head-rgbw: op-zOutputted files not changed.💤 lixada/mini-moving-head-rgbw: qlcplus_4.12.1Outputted files not changed.💤 martin/mac-axiom-hybrid: colorsourceOutputted files not changed.💤 martin/mac-axiom-hybrid: d-lightOutputted files not changed.💤 martin/mac-axiom-hybrid: ecueOutputted files not changed.💤 martin/mac-axiom-hybrid: milluminOutputted files not changed.💤 martin/mac-axiom-hybrid: op-zOutputted files not changed.💤 martin/mac-axiom-hybrid: qlcplus_4.12.1Outputted files not changed.💤 martin/mac-encore-performance: colorsourceOutputted files not changed.💤 martin/mac-encore-performance: d-lightOutputted files not changed.💤 martin/mac-encore-performance: ecueOutputted files not changed.💤 martin/mac-encore-performance: milluminOutputted files not changed.💤 martin/mac-encore-performance: op-zOutputted files not changed.💤 martin/mac-encore-performance: qlcplus_4.12.1Outputted files not changed.💤 martin/mania-scx500: colorsourceOutputted files not changed.💤 martin/mania-scx500: d-lightOutputted files not changed.💤 martin/mania-scx500: ecueOutputted files not changed.💤 martin/mania-scx500: milluminOutputted files not changed.💤 martin/mania-scx500: op-zOutputted files not changed.💤 martin/mania-scx500: qlcplus_4.12.1Outputted files not changed.💤 mdg/theone-atmospheric-generator: colorsourceOutputted files not changed.💤 mdg/theone-atmospheric-generator: d-lightOutputted files not changed.💤 mdg/theone-atmospheric-generator: ecueOutputted files not changed.💤 mdg/theone-atmospheric-generator: milluminOutputted files not changed.💤 mdg/theone-atmospheric-generator: op-zOutputted files not changed.💤 mdg/theone-atmospheric-generator: qlcplus_4.12.1Outputted files not changed.💤 prolights/diamond19: colorsourceOutputted files not changed.💤 prolights/diamond19: d-lightOutputted files not changed.💤 prolights/diamond19: ecueOutputted files not changed.💤 prolights/diamond19: milluminOutputted files not changed.💤 prolights/diamond19: op-zOutputted files not changed.💤 prolights/diamond19: qlcplus_4.12.1Outputted files not changed.💤 qtx/lux-ld01: colorsourceOutputted files not changed.💤 qtx/lux-ld01: d-lightOutputted files not changed.💤 qtx/lux-ld01: ecueOutputted files not changed.💤 qtx/lux-ld01: milluminOutputted files not changed.💤 qtx/lux-ld01: op-zOutputted files not changed.💤 qtx/lux-ld01: qlcplus_4.12.1Outputted files not changed.💤 robe/robin-600e-spot: colorsourceOutputted files not changed.💤 robe/robin-600e-spot: d-lightOutputted files not changed.💤 robe/robin-600e-spot: ecueOutputted files not changed.💤 robe/robin-600e-spot: milluminOutputted files not changed.💤 robe/robin-600e-spot: op-zOutputted files not changed.💤 robe/robin-600e-spot: qlcplus_4.12.1Outputted files not changed.🆚 showtec/phantom-50-led-spot: colorsource
🆚 showtec/phantom-50-led-spot: d-light
🆚 showtec/phantom-50-led-spot: ecue
🆚 showtec/phantom-50-led-spot: millumin
💤 showtec/phantom-50-led-spot: op-zOutputted files not changed.🆚 showtec/phantom-50-led-spot: qlcplus_4.12.1
💤 stairville/mh-x30: colorsourceOutputted files not changed.💤 stairville/mh-x30: d-lightOutputted files not changed.💤 stairville/mh-x30: ecueOutputted files not changed.💤 stairville/mh-x30: milluminOutputted files not changed.💤 stairville/mh-x30: op-zOutputted files not changed.💤 stairville/mh-x30: qlcplus_4.12.1Outputted files not changed. |
Closes #1181.
res
points to a valid resource file