Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop QLC+ 4.11.2 plugin #1186

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Drop QLC+ 4.11.2 plugin #1186

merged 2 commits into from
Jan 30, 2020

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented Jan 30, 2020 •
edited
Loading

QLC+ 4.12 is out for some time now, and v4.12.2 seems to be a quite stable release.

Also, the exported file path in the QLC+ 4.12.1 export plugin is changed: It is now prefixed with the fixtures/ directory. This doesn't change the download logic for now (also only the .qxf file is downloaded), but will make the diff in #1185 more readable.

@FloEdelmann FloEdelmann added the component-plugin Affects one or more import or export plugins. label Jan 30, 2020
@FloEdelmann FloEdelmann temporarily deployed to ofl-drop-qlcplus-4-11-2-x4ekhx January 30, 2020 19:53 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ afx / lmh460z: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/AFX-LMH460Z.qxf
✔️ afx / lmh460z: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/AFX-LMH460Z.qxf
✔️ astera / fp1-titan-tube: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Astera-FP1-Titan-Tube.qxf
✔️ astera / fp1-titan-tube: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Astera-FP1-Titan-Tube.qxf
✔️ ayrton / magicblade-fx: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Ayrton-MagicBlade-FX.qxf
✔️ ayrton / magicblade-fx: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Ayrton-MagicBlade-FX.qxf
✔️ cameo / auro-spot-400: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/cameo-Auro-Spot-400.qxf
✔️ cameo / auro-spot-400: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/cameo-Auro-Spot-400.qxf
✔️ cameo / hydrabeam-300-rgbw: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/cameo-Hydrabeam-300-RGBW.qxf
✔️ cameo / hydrabeam-300-rgbw: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/cameo-Hydrabeam-300-RGBW.qxf
✔️ flash-professional / led-moving-head-150w: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Flash-Professional-LED-Moving-Head-150W.qxf
✔️ flash-professional / led-moving-head-150w: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Flash-Professional-LED-Moving-Head-150W.qxf
❌ generic / pan-tilt: qlcplus_4.12.1 / fixture-tool-validation
  • ❌ fixtures/Generic-PanTilt-Fader.qxfNamespace(convert=None, map=False, validate=['.']) manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
❌ generic / pan-tilt: qlcplus_4.12.1 / xsd-schema-conformity
  • ❌ fixtures/Generic-PanTilt-Fader.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
✔️ glp / impression-laser: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/GLP-impression-Laser.qxf
✔️ glp / impression-laser: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/GLP-impression-Laser.qxf
✔️ glp / knv-arc: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/GLP-KNV-Arc.qxf
✔️ glp / knv-arc: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/GLP-KNV-Arc.qxf
✔️ lixada / mini-moving-head-rgbw: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Lixada-Mini-Moving-Head-RGBW.qxf
✔️ lixada / mini-moving-head-rgbw: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Lixada-Mini-Moving-Head-RGBW.qxf
✔️ martin / mac-axiom-hybrid: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Martin-MAC-Axiom-Hybrid.qxf
✔️ martin / mac-axiom-hybrid: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Martin-MAC-Axiom-Hybrid.qxf
✔️ martin / mac-encore-performance: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Martin-MAC-Encore-Performance.qxf
✔️ martin / mac-encore-performance: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Martin-MAC-Encore-Performance.qxf
✔️ martin / mania-scx500: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Martin-Mania-SCX500.qxf
✔️ martin / mania-scx500: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Martin-Mania-SCX500.qxf
✔️ mdg / theone-atmospheric-generator: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/MDG-theONE-Atmospheric-Generator.qxf
✔️ mdg / theone-atmospheric-generator: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/MDG-theONE-Atmospheric-Generator.qxf
✔️ prolights / diamond19: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Prolights-DIAMOND19.qxf
✔️ prolights / diamond19: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Prolights-DIAMOND19.qxf
✔️ qtx / lux-ld01: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/QTX-Lux-Ld01.qxf
✔️ qtx / lux-ld01: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/QTX-Lux-Ld01.qxf
✔️ robe / robin-600e-spot: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Robe-Robin-600E-Spot.qxf
✔️ robe / robin-600e-spot: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Robe-Robin-600E-Spot.qxf
✔️ stairville / mh-x30: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ fixtures/Stairville-MH-x30.qxf
✔️ stairville / mh-x30: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ fixtures/Stairville-MH-x30.qxf

@FloEdelmann
Copy link
Member Author

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 afx/lmh460z: qlcplus_4.12.1
Removed files
  • AFX-LMH460Z.qxf
Added files
  • fixtures/
  • fixtures/AFX-LMH460Z.qxf
🆚 astera/fp1-titan-tube: qlcplus_4.12.1
Removed files
  • Astera-FP1-Titan-Tube.qxf
Added files
  • fixtures/
  • fixtures/Astera-FP1-Titan-Tube.qxf
🆚 ayrton/magicblade-fx: qlcplus_4.12.1
Removed files
  • Ayrton-MagicBlade-FX.qxf
Added files
  • fixtures/
  • fixtures/Ayrton-MagicBlade-FX.qxf
🆚 cameo/auro-spot-400: qlcplus_4.12.1
Removed files
  • cameo-Auro-Spot-400.qxf
Added files
  • fixtures/
  • fixtures/cameo-Auro-Spot-400.qxf
🆚 cameo/hydrabeam-300-rgbw: qlcplus_4.12.1
Removed files
  • cameo-Hydrabeam-300-RGBW.qxf
Added files
  • fixtures/
  • fixtures/cameo-Hydrabeam-300-RGBW.qxf
🆚 flash-professional/led-moving-head-150w: qlcplus_4.12.1
Removed files
  • Flash-Professional-LED-Moving-Head-150W.qxf
Added files
  • fixtures/
  • fixtures/Flash-Professional-LED-Moving-Head-150W.qxf
🆚 generic/pan-tilt: qlcplus_4.12.1
Removed files
  • Generic-PanTilt-Fader.qxf
Added files
  • fixtures/
  • fixtures/Generic-PanTilt-Fader.qxf
🆚 glp/impression-laser: qlcplus_4.12.1
Removed files
  • GLP-impression-Laser.qxf
Added files
  • fixtures/
  • fixtures/GLP-impression-Laser.qxf
🆚 glp/knv-arc: qlcplus_4.12.1
Removed files
  • GLP-KNV-Arc.qxf
Added files
  • fixtures/
  • fixtures/GLP-KNV-Arc.qxf
🆚 lixada/mini-moving-head-rgbw: qlcplus_4.12.1
Removed files
  • Lixada-Mini-Moving-Head-RGBW.qxf
Added files
  • fixtures/
  • fixtures/Lixada-Mini-Moving-Head-RGBW.qxf
🆚 martin/mac-axiom-hybrid: qlcplus_4.12.1
Removed files
  • Martin-MAC-Axiom-Hybrid.qxf
Added files
  • fixtures/
  • fixtures/Martin-MAC-Axiom-Hybrid.qxf
🆚 martin/mac-encore-performance: qlcplus_4.12.1
Removed files
  • Martin-MAC-Encore-Performance.qxf
Added files
  • fixtures/
  • fixtures/Martin-MAC-Encore-Performance.qxf
🆚 martin/mania-scx500: qlcplus_4.12.1
Removed files
  • Martin-Mania-SCX500.qxf
Added files
  • fixtures/
  • fixtures/Martin-Mania-SCX500.qxf
🆚 mdg/theone-atmospheric-generator: qlcplus_4.12.1
Removed files
  • MDG-theONE-Atmospheric-Generator.qxf
Added files
  • fixtures/
  • fixtures/MDG-theONE-Atmospheric-Generator.qxf
🆚 prolights/diamond19: qlcplus_4.12.1
Removed files
  • Prolights-DIAMOND19.qxf
Added files
  • fixtures/
  • fixtures/Prolights-DIAMOND19.qxf
🆚 qtx/lux-ld01: qlcplus_4.12.1
Removed files
  • QTX-Lux-Ld01.qxf
Added files
  • fixtures/
  • fixtures/QTX-Lux-Ld01.qxf
🆚 robe/robin-600e-spot: qlcplus_4.12.1
Removed files
  • Robe-Robin-600E-Spot.qxf
Added files
  • fixtures/
  • fixtures/Robe-Robin-600E-Spot.qxf
🆚 stairville/mh-x30: qlcplus_4.12.1
Removed files
  • Stairville-MH-x30.qxf
Added files
  • fixtures/
  • fixtures/Stairville-MH-x30.qxf

@FloEdelmann FloEdelmann merged commit fe99a8a into master Jan 30, 2020
@FloEdelmann FloEdelmann deleted the drop-qlcplus-4.11.2 branch January 30, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxedel fxedel fxedel approved these changes

Assignees
No one assigned
Labels
component-plugin Affects one or more import or export plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @fxedel