Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ndarray 0.16 #439

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support ndarray 0.16 #439

wants to merge 5 commits into from

Conversation

magnusuMET
Copy link

Fixes #438

@magnusuMET
Copy link
Author

This PR is blocked on rust-ndarray/ndarray-linalg#379

@bluss
Copy link

bluss commented Aug 20, 2024

Previous discussion about ndarray 0.16, rust-numpy and ndarray-linalg: rust-ndarray/ndarray#1374

@bluss
Copy link

bluss commented Aug 20, 2024

Ok, that comment was maybe not super helpful - ndarray 0.16 got a few more changes since that happened. But I think it points out that ndarray-linalg doesn't need to be a strict blocker for this update.

@magnusuMET
Copy link
Author

I see the main argument: Allow the deprecation and let the end user deal with the dependency through their lockfile. I am not sure how to create a lockfile with the right dependency through cargo invocations, but checking in the lockfile should hopefully work

@bluss
Copy link

bluss commented Aug 21, 2024

Some more deprecated methods were removed in ndarray post adamreichold's test.
I would suggest maybe restricting to ndarray 0.15 and 0.16 if possible (this is not my project -- just how I would do it); I don't usually work with open ranges of dependencies so don't really know.

Hoping ndarray-linalg can be tested using ndarray 0.15 only suggested. With that said, we should be able to get a solution (to update) ndarray-linalg sooner or later..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ndarray 0.16
2 participants