-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ndarray 0.16 #439
base: main
Are you sure you want to change the base?
Support ndarray 0.16 #439
Conversation
This PR is blocked on rust-ndarray/ndarray-linalg#379 |
Previous discussion about ndarray 0.16, rust-numpy and ndarray-linalg: rust-ndarray/ndarray#1374 |
Ok, that comment was maybe not super helpful - ndarray 0.16 got a few more changes since that happened. But I think it points out that ndarray-linalg doesn't need to be a strict blocker for this update. |
I see the main argument: Allow the deprecation and let the end user deal with the dependency through their lockfile. I am not sure how to create a lockfile with the right dependency through cargo invocations, but checking in the lockfile should hopefully work |
Some more deprecated methods were removed in ndarray post adamreichold's test. Hoping ndarray-linalg can be tested using ndarray 0.15 only suggested. With that said, we should be able to get a solution (to update) ndarray-linalg sooner or later.. |
Fixes #438