Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ndarray and other deps #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dirreke
Copy link

@Dirreke Dirreke commented Aug 5, 2024

Bump ndarray from 0.15.6 to 0.16.0
Bump approx from 0.4.0 to 0.5
Bump criterion from 0.3.4 to 0.5.1

@Dirreke
Copy link
Author

Dirreke commented Aug 14, 2024

sorry, I forget to update tests file. I will fix it later today

@Dirreke
Copy link
Author

Dirreke commented Aug 14, 2024

Fixed, Let's rerun CI

@bluss
Copy link
Member

bluss commented Aug 14, 2024

hi - I was here to press the ci button but I was wondering if @termoshtt wants to chime in too

@Dirreke
Copy link
Author

Dirreke commented Aug 14, 2024

It seems like we should bump MSRV. Or limit the version of clap. Which one would you like?
I could open a new PR to fix it.

@govinda-kamath
Copy link

Hi - any update on this. This seems to be holding back ndarray updates downstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants