[review] EventBridge Scheduler のスケジュール登録 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzkn
force-pushed
the
kzkn-20231013-eventbridge-scheduler
branch
from
f8d2c7c
to
f6e4169
Compare
kzkn
changed the title
interu
reviewed
Oct 19, 2023
| @command = command | ||
| end | ||
|
|
||
| def create_run_task(group_name:, cluster_arn:, task_definition_arn:, network_configuration:) |
There was a problem hiding this comment.
ruby 3.1の記法じゃなかったっけ？3.0とかでもOKだったっけ？
There was a problem hiding this comment.
ここはメソッドのキーワード引数（必須）なので、前から書けるはず。
3.1 からのやつはハッシュリテラルの省略記法ですね。
a = 1
{ a: } # => { a: 1 }
interu
approved these changes
Oct 19, 2023
[review] コンテナスペックの切り替え指定ができるように
[review] run_taskのコンテナスペックを選択制に変更
merge main
[review] config/eventbridge_schedules.ymlでRAILS_ENVごとにスケジュールを調整できるように
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.