Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to avoid NCZARR-related warning (low priority -- annoyance only) #2939

Closed
gsjaardema opened this issue Jun 26, 2024 · 1 comment · Fixed by #2940
Closed

Unable to avoid NCZARR-related warning (low priority -- annoyance only) #2939

gsjaardema opened this issue Jun 26, 2024 · 1 comment · Fixed by #2940

Comments

@gsjaardema
Copy link
Contributor

I get the following warning during a configuration of 4.9.2 and also Wards' 4.9.3.wif:

CMake Warning at CMakeLists.txt:1656 (MESSAGE):
  ENABLE_NCZARR==NO => ENABLE_NCZARR_FILTERS==NO AND
  ENABLE_NCZARR_FILTER_TESTING==NO

I have tried using the folliowing and still get the warning:

	 -D${PREFIX}ENABLE_NCZARR_FILTERS:BOOL=OFF \
	 -D${PREFIX}ENABLE_NCZARR_FILTER_TESTING:BOOL=OFF \
	 -D${PREFIX}ENABLE_NCZARR:BOOL=OFF \

Note that ${PREFIX} is empty for 4.9.2 and NETCDF_ for main and 4.9.3.wif.
I think the warning should check that the variables that it is warning about are not set and if they are, don't emit the warning.

@DennisHeimbigner
Copy link
Collaborator

The problem is that I was looking for certain cases of the form

if( not x and y)
message(warning "not x => not y)
endif

However in a couple of cases (including the one you encountered), I was only testing

if( not x)
message(warning "not x => not y)
endif

I will post a fix shortly.

DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this issue Jun 26, 2024
re: Issue Unidata#2939

The problem managing inter-dependent options.
I was looking for certain cases of the form, where x and y are options.
````
if( not x and y)
message(warning "not x => not y)
endif
````
However in a couple of cases (including the referenced Issue), I was only testing this:
````
if( not x)
message(warning "not x => not y)
endif
````

Fix is to correct the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants