Fix some warnings in cmake #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Issue Unidata#2939 The problem managing inter-dependent options. I was looking for certain cases of the form, where x and y are options. ```` if( not x and y) message(warning "not x => not y) endif ```` However in a couple of cases (including the referenced Issue), I was only testing this: ```` if( not x) message(warning "not x => not y) endif ```` Fix is to correct the tests.
WardF
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Issue #2939
The problem occurs when managing inter-dependent options.
I was testing for certain dependencies of the form
not x => not ywhere x and y are options.This should be encoded in CMakeLists.txt as follows:
However in a couple of cases (including the referenced Issue), I was only testing this:
Fix is to correct the tests.