Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Serials to Kinds to match keripy #275

Closed
wants to merge 6 commits into from

Conversation

SmithSamuelM
Copy link
Contributor

No description provided.

@SmithSamuelM
Copy link
Contributor Author

SmithSamuelM commented Jul 26, 2024

Needs to update github tests to test against WebOfTrust/keripy#826 which needs to get a new dev tag once accepted so keria can reference the new dev tag for keripy

@m00sey
Copy link
Member

m00sey commented Jul 30, 2024

@m00sey to create keripy dev tag

@m00sey
Copy link
Member

m00sey commented Jul 31, 2024

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (18d3ad7) to head (a348170).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   93.06%   93.10%   +0.04%     
==========================================
  Files          36       36              
  Lines        7121     7221     +100     
==========================================
+ Hits         6627     6723      +96     
- Misses        494      498       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… keripy Encrypter to support all types of ciphers.
@iFergal
Copy link
Contributor

iFergal commented Aug 22, 2024

@m00sey This can merge if we get a dev13 version which is required for the latest changes to encrypter.encrypt. Tested locally against keripy main and all the tests pass.

@iFergal
Copy link
Contributor

iFergal commented Aug 27, 2024

@SmithSamuelM Phil published 1.2.0-dev13 so if this PR is updated it should be ready to merge

@m00sey m00sey self-requested a review August 28, 2024 13:23
Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces new errors:

TypeError: SaltyManager.rotate() missing 2 required positional arguments: 'kidx' and 'transferable'
TypeError: Encrypter.encrypt() got an unexpected keyword argument 'prim'

@kentbull
Copy link
Contributor

#294 duplicates this.

@iFergal
Copy link
Contributor

iFergal commented Sep 19, 2024

This can be closed now that #294 has merged!

@2byrds 2byrds closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants