Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now uses versioned Counter class in core.counting everywhere. Old unversioned coring.Counter has been removed. #826

Merged
merged 14 commits into from
Jul 27, 2024

Conversation

SmithSamuelM
Copy link
Collaborator

This is the first major step in supporting verisoned CESR with versioned count codes.
Next steps,

  • Change parser and other places that parse count codes to dynamically determine version of incoming message stream and apply the correct version of Counter with count codes.
  • Make default generation of count codes in output streams use the version 2 codes which requires that generation logic convert to always counting quadlets not groups of primitives.

@SmithSamuelM
Copy link
Collaborator Author

@pfeairheller I didn't merge this yet because wanted you to be appriased of it. I checked and it does not break anything in Keria, because Keria does not directly reference Counter or CtrDex. I didn't know if something else might break.

… variable nanme we use is kind for serialization kind but the namedtuple was called Serials. This realigns the naming.
@SmithSamuelM
Copy link
Collaborator Author

SmithSamuelM commented Jul 26, 2024

The last commit breaks Keria so I fixed Keria as well but keripy needs new dev tag to github tests pass for keria

@SmithSamuelM SmithSamuelM merged commit 7d78294 into WebOfTrust:main Jul 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant