Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calculation of Summary Loads #3374

Closed
rajadain opened this issue Oct 8, 2020 · 2 comments
Closed

Fix Calculation of Summary Loads #3374

rajadain opened this issue Oct 8, 2020 · 2 comments
Assignees
Labels
+ bug MapShed PA DEP Funding Source: Pennsylvania Department of Environment Protection production

Comments

@rajadain
Copy link
Member

rajadain commented Oct 8, 2020

BME noticed that the MapShed Summary Loads were not being calculated correctly. The Detail / Per Land Use loads are calculated correctly.

image

According to him, it seems like the Total Loads is missing the Low-Density Open Space land use type. This may affect the Loading Rates number as well. Furthermore, it seems like the denominator when calculating Loading Rates includes Open Water, which reduces the final number. Loading Rates should be calculated only for land, thus Open Water should be excluded. Loading Rates should be calculated for the entire area, including Open Water.

BME will send over the name of a test watershed and the numbers he expects to see. They will be attached thence herein.

@rajadain rajadain added bug production MapShed NSF Funding Source: National Science Foundation labels Oct 8, 2020
@rajadain rajadain self-assigned this Oct 8, 2020
@rajadain
Copy link
Member Author

rajadain commented Oct 8, 2020

From BME:

Thanks for meeting today. FYI, the HUC12 sub-watershed I used for my example is "City of Gahanna-Big Walnut Creek". The sediment loads calculated when you run the multi-year model now are 1,898,674.2 (for total load) and 598.99 (for loading rate). As discussed, however, they should be 1,910,294.3 and 471.68, respectively. Again, as discussed, the load for "Developed Open Space" needs to be added to the total load. Also, the area for "Water" needs to be subtracted, and the area for "Developed Open Space" needs to be added prior to doing the loading rate calculation (i.e., total kg / hectares of land area).

@rajadain
Copy link
Member Author

He sent over this file to better help explain the issue: MMWLoadFixes.xlsx

@rajadain rajadain added NSF Funding Source: National Science Foundation PA DEP Funding Source: Pennsylvania Department of Environment Protection and removed NSF Funding Source: National Science Foundation labels Dec 27, 2021
@rajadain rajadain mentioned this issue Dec 27, 2021
30 tasks
rajadain added a commit to WikiWatershed/gwlf-e that referenced this issue Dec 27, 2021
rajadain added a commit to WikiWatershed/gwlf-e that referenced this issue Dec 27, 2021
rajadain added a commit to WikiWatershed/gwlf-e that referenced this issue Dec 27, 2021
@rajadain rajadain added the + label Dec 27, 2021
rajadain added a commit to WikiWatershed/gwlf-e that referenced this issue Dec 28, 2021
rajadain added a commit to WikiWatershed/gwlf-e that referenced this issue Dec 28, 2021
Low Density Open Space was added, and Other Upland Areas
removed in #84. Unfortunately, the total calculation was
not updated correspondingly. That is fixed here.

Refs WikiWatershed/model-my-watershed#3374
@rajadain rajadain removed the NSF Funding Source: National Science Foundation label Dec 29, 2021
@rajadain rajadain closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+ bug MapShed PA DEP Funding Source: Pennsylvania Department of Environment Protection production
Projects
None yet
Development

No branches or pull requests

1 participant