Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GWLF-E to 3.1.0 to fix SummaryLoad calcs #3449

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Upgrade GWLF-E to 3.1.0 to fix SummaryLoad calcs #3449

merged 1 commit into from
Jan 4, 2022

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Dec 29, 2021 •
edited by emilyhu0106
Loading

Overview

Previously the SummaryLoad calculations did not take into account the changes from WikiWatershed/gwlf-e#84. This was fixed in WikiWatershed/gwlf-e#89 and is pulled in here.

Connects WikiWatershed/gwlf-e#89
Connects #3374

Testing Instructions

  • Check out this branch and provision the app and worker 
    vagrant provision app worker
  • Go to http://localhost:8000 and draw a new shape
  • Model it with Watershed Multi-Year Model
  • Switch to the Water Quality tab of the results
    • Ensure the value of Total Loads (kg) of Sediment in the top table is equal to the sum of Sediment (kg) loads of all the Sources in the bottom table

@rajadain rajadain added the PA DEP Funding Source: Pennsylvania Department of Environment Protection label Dec 29, 2021
emilyhu0106
emilyhu0106 reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@emilyhu0106 emilyhu0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested different ways of area selection and the new GWLF-E works very well!

@emilyhu0106 emilyhu0106 assigned rajadain and unassigned emilyhu0106 Jan 4, 2022
@rajadain
Copy link
Member Author

rajadain commented Jan 4, 2022

Thanks for taking a look!

@rajadain rajadain merged commit a77fdb4 into develop Jan 4, 2022
@rajadain rajadain deleted the tt/upgrade-gwlf-e branch January 4, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyhu0106 emilyhu0106 emilyhu0106 approved these changes

Assignees

@rajadain rajadain

Labels
PA DEP Funding Source: Pennsylvania Department of Environment Protection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajadain @emilyhu0106