v4.4.1: Merging beta into main #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
##### In this PR - Adding a `.max` that we forgot when implementing Essence damage ##### Testing - Dropping and deleting a Focus on an actor should no longer error
##### In this PR - Reworking Essence migrations to handle: 1. Standard Essence damage migration 2. Possible case where essence.max.max existed 3. Previous migration may have set it to a SchemaField() - Adding missing awaits to setRoleValues and setFocusValues, which were causing race conditions ##### Testing - Checkout 63b8d08 (this is pre-Essence damage) - Create a character - Checkout ecbf803 (this is post-Essence damage, but the migration throws in a SchemaField) - No errors/Essences are fine - Checkout this branch (this fixes remaining migration issues) - No errors/Essences are fine - Setting Essence values and leveling for the actor should work as expected (correct values and no flickering)
##### In this PR - Vehicles need notes too! ##### Testing - Notes should save as normal on vehicles and other characters
In this PR fixes initial name change issue for embedded documents. Testing
JFranklin3000
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [issue URL]
In this PR
Testing