LNURL-auth support for LNDHub #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
reviewed
Jan 6, 2023
views/Receive.tsx
Outdated
| NfcEvents, | ||
| TagEvent, | ||
| Ndef | ||
| } from 'react-native-nfc-manager'; |
There was a problem hiding this comment.
I think the edits on this file were all intended for your other PR
There was a problem hiding this comment.
Looks like I branched off that one accidentally. Clearly wasn’t paying attention.
will fix
kaloudis
reviewed
Jan 6, 2023
| lnurlAuth = () => | ||
| Promise.resolve({ | ||
| signature: `lndhub://${stores.settingsStore.username}:${stores.settingsStore.password}` | ||
| }); |
There was a problem hiding this comment.
I thought there was an actual /auth endpoint we could use
There was a problem hiding this comment.
That endpoint was for actual LNDHub auth (fetching an auth token) - didn’t actually do any message signing
kaloudis
reviewed
Jan 6, 2023
| @@ -336,10 +336,12 @@ export default class LND { | |||
| msg: Base64Utils.btoa(data.msg), | |||
| signature: data.signature | |||
| }); | |||
| lnurlAuth = (r_hash: string) => this.signMessage(r_hash); | |||
There was a problem hiding this comment.
love what you've done here, wrapping up the signMessage method for the new call
kaloudis
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: ZEUS-1045
Added support for LNURL-auth for LNDHub backend with signature being
lndhub://user:passrather than typical message signing.Also made a slight adjustment on the LnurlAuth view to center the domain inline with all other components.
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandpackage-lock.jsonhave been properly updatedOther: