-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LNURL-auth support for LNDHub #1254
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,8 +74,13 @@ export default class LndHub extends LND { | |
invoice: data.payment_request, | ||
amount: Number(data.amt && data.amt * 1000) | ||
}); | ||
lnurlAuth = () => | ||
Promise.resolve({ | ||
signature: `lndhub://${stores.settingsStore.username}:${stores.settingsStore.password}` | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought there was an actual There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That endpoint was for actual LNDHub auth (fetching an auth token) - didn’t actually do any message signing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Corrected! |
||
|
||
supportsMessageSigning = () => false; | ||
supportsLnurlAuth = () => true; | ||
supportsOnchainSends = () => false; | ||
supportsOnchainReceiving = () => | ||
!( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love what you've done here, wrapping up the
signMessage
method for the new call