Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native to 0.72.10 #1988

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Update react-native to 0.72.10 #1988

merged 3 commits into from
Feb 25, 2024

Conversation

myxmaster
Copy link
Contributor

Description

Updated react-native to 0.72.10 in preparation for update to 0.73.

Also updated other react-native related packages and metro config. Podfile might need to be updated.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.8.2 milestone Feb 19, 2024
@kaloudis
Copy link
Contributor

We have a blocker here. We need to upgrade the docker image in our build.sh reproducible builds script to something with a higher version of NodeJS

error @react-native/babel-preset@0.73.21: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.2"

https://github.com/react-native-community/docker-android/blob/v7.0/Dockerfile#L22

react-native-community/docker-android v8.0 - v13.0, use NodeJS v18

@kaloudis
Copy link
Contributor

Working on the Docker image bump here: #1995

@myxmaster myxmaster mentioned this pull request Feb 22, 2024
29 tasks
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis
Copy link
Contributor

iOS Podfile.lock and project file updated (new RN fixed an annoying bug with the build flags repeating)

@kaloudis
Copy link
Contributor

Successfully running on iOS and Android. Build tests next

@kaloudis
Copy link
Contributor

Successfully built on iOS and Android

@kaloudis kaloudis merged commit 175143e into ZeusLN:master Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants