-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-native to 0.72.10 #1988
Conversation
We have a blocker here. We need to upgrade the docker image in our
https://github.com/react-native-community/docker-android/blob/v7.0/Dockerfile#L22 react-native-community/docker-android v8.0 - v13.0, use NodeJS v18 |
Working on the Docker image bump here: #1995 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
iOS Podfile.lock and project file updated (new RN fixed an annoying bug with the build flags repeating) |
Successfully running on iOS and Android. Build tests next |
Successfully built on iOS and Android |
Description
Updated react-native to 0.72.10 in preparation for update to 0.73.
Also updated other react-native related packages and metro config. Podfile might need to be updated.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: