Upgrade react-native to 0.73.4

[myxmaster]

Description

Based on #1988.

Updated lots of react-native and other packages.

There was a problem with the react-native-tor package which is described here: Sifir-io/react-native-tor#57
I created a workaround by removing the incompatible JNI in the library.

All the updates for iOS related files still need to be done:
https://react-native-community.github.io/upgrade-helper/?from=0.72.10&to=0.73.4

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[kaloudis]

Hitting a bunch of pods issues. Gonna have to roll my sleeves up on the iOS side

[kaloudis]

iOS changes pushed

[kaloudis]

any reason why node patches/patch-sifir_android.mjs isn't made part of the patch command instead?

[myxmaster]

Well, it's only git patches... and jetifier stuff is also not part of the patch command.

[kaloudis]

I think it should go along with the patches

[kaloudis]

On a fresh install the following error is thrown:

      throw er; // Unhandled 'error' event
      ^

Error: ENOENT: no such file or directory, scandir 'node_modules/react-native-tor/android/libs/sifir_android/META-INF/com/android/build'
Emitted 'error' event at:
    at onreaddir (/Users/satoshi/Repos/kaloudis/zeus/node_modules/findit/index.js:116:21)
    at /Users/satoshi/Repos/kaloudis/zeus/node_modules/findit/index.js:31:17
    at FSReqCallback.oncomplete (node:fs:191:23) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: 'node_modules/react-native-tor/android/libs/sifir_android/META-INF/com/android/build'
}

Node.js v20.11.1

[kaloudis]

On a fresh install the following error is thrown:

      throw er; // Unhandled 'error' event
      ^

Error: ENOENT: no such file or directory, scandir 'node_modules/react-native-tor/android/libs/sifir_android/META-INF/com/android/build'
Emitted 'error' event at:
    at onreaddir (/Users/satoshi/Repos/kaloudis/zeus/node_modules/findit/index.js:116:21)
    at /Users/satoshi/Repos/kaloudis/zeus/node_modules/findit/index.js:31:17
    at FSReqCallback.oncomplete (node:fs:191:23) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: 'node_modules/react-native-tor/android/libs/sifir_android/META-INF/com/android/build'
}

Node.js v20.11.1

this goes away if node patches/patch-sifir_android.mjs is moved to patch. File must be made with jetify