Bolt12 Human Readable Offers #1989
Conversation
|
Awesome first time contribution! |
assets/images/SVG/AtSign.svg
Outdated
There was a problem hiding this comment.
There is an AddressSvg you can use here instead that is effectively the same symbol
| @@ -7,5 +7,5 @@ | |||
| # | |||
| # Customize the NODE_BINARY variable here. | |||
| # For example, to use nvm with brew, add the following line | |||
| # . "$(brew --prefix nvm)/nvm.sh" --no-use | |||
| . "$(brew --prefix nvm)/nvm.sh" --no-use | |||
There was a problem hiding this comment.
was this change required for your env? would rather it be unchanged
ios/zeus.xcodeproj/project.pbxproj
Outdated
There was a problem hiding this comment.
Any specific changes here necessary?
ios/zeus/zeus.entitlements
Outdated
There was a problem hiding this comment.
Any reason to remove these tags for NFC?
ios/zeus/zeusRelease.entitlements
Outdated
There was a problem hiding this comment.
Any reason to remove these tags for NFC?
| @@ -839,6 +840,10 @@ | |||
| "views.Settings.Contacts.noAddress": "No Address", | |||
| "views.Settings.Contacts.to": "To", | |||
| "views.Settings.Contacts.deleteAllContacts": "Delete all contacts", | |||
| "views.Settings.Bolt12Address.bolt12Address": "Bolt12 Address", | |||
There was a problem hiding this comment.
nit: we change between styling it as Bolt 12 and Bolt12. We should be consistent
|
|
||
| if (BackendUtils.supportsOffers()) { | ||
| const [localPart, domain] = value.split('@'); | ||
| const dnsUrl = 'https://cloudflare-dns.com/dns-query'; |
There was a problem hiding this comment.
love to see the query code already in place. this is a well trusted resolver but I'm curious if there are any other ways we can do the query
| } | ||
|
|
||
| try { | ||
| const res = await fetch('https://twelve.cash/record', { |
There was a problem hiding this comment.
I have some qualms about adding a third party service here. I'll have to do some more research about it.
| getNewOffer = () => | ||
| this.postRequest('/v1/offers/offer', { | ||
| amount: 'any', | ||
| description: 'Bolt12 Payment Address' |
There was a problem hiding this comment.
do we perhaps want to add the ability to generate Bolt12 offers manually on the receive page too?
|
Closing in favor of #2207 Want to leave this branch intact just in case we need to review old changes for whatever reason. |
Description
An example of human readable offers using DNS TXT records. This is an early POC attempt inspired by the latest discussions around human readable names mapping to payment info. The goal of this draft is to gauge interest and hopefully help push bolt12 forward.
The bolt12 address option is currently only enabled for core lightning nodes with experimental offers enabled.
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: