Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 12: offers + Twelve.cash lightning address #2207

Merged
merged 8 commits into from
May 28, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented May 24, 2024

Description

Adds support for human readable BOLT 12 lightning addresses from Twelve.cash for the c-lightning-REST interface. Supercedes #1989

Also adds support for generating generic BOLT 12 offers, labeled Pay codes

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Co-authored-by: Chad Welch <cwelc001@gmail.com>
@kaloudis kaloudis added this to the v0.9.0 milestone May 24, 2024
Co-authored-by: Chad Welch <cwelc001@gmail.com>
Co-authored-by: Stephen DeLorme <stephen@d.elor.me>
@kaloudis kaloudis mentioned this pull request May 24, 2024
23 tasks
@kaloudis kaloudis marked this pull request as ready for review May 24, 2024 23:40
@kaloudis kaloudis force-pushed the twelvecash branch 2 times, most recently from c6a7887 to 2c101d9 Compare May 25, 2024 00:05
Co-authored-by: Chad Welch <cwelc001@gmail.com>
@kaloudis
Copy link
Contributor Author

Support for generic offer creation added, as Pay codes

simulator_screenshot_78563436-FCF5-4035-8980-0D13DD8AF983
simulator_screenshot_E3CFDBAE-B6DB-44AF-893A-8880E3E6AEAA
simulator_screenshot_BBAAA4B6-24FA-4884-9420-4C74A9CE4D76
simulator_screenshot_4D49DF77-A6AF-4DCA-96F2-95AD8F0DD92D

@kaloudis kaloudis changed the title BOLT 12 Human Readable Offers BOLT 12: offers + Twelve.cash lightning address May 25, 2024
@kaloudis kaloudis merged commit b4ef7a5 into ZeusLN:master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant