Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ng-disabled on md-icon in md-list-item does not work #3356

Closed
shalabhaggarwal opened this issue Jun 19, 2015 · 4 comments
Closed

ng-disabled on md-icon in md-list-item does not work #3356

shalabhaggarwal opened this issue Jun 19, 2015 · 4 comments
Assignees
@topherfangio
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone
1.0-rc6

Comments

@shalabhaggarwal
Copy link

When ng-disabled is applied on md-icon acting as a secondary on md-list-item, it does not have any effect on the dynamically generated button which still fires.

Here is a codepen: http://codepen.io/anon/pen/bdoqLb
@mukilane
Copy link

Duplicate of #3176
Pls close.

@shalabhaggarwal
Copy link
Author

I dont think #3176 covers the case for ng-disabled.

@ThomasBurleson ThomasBurleson self-assigned this Jul 6, 2015
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jul 6, 2015
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 0.12.0 Sep 2, 2015
@topherfangio topherfangio modified the milestones: 0.12, 0.13 Oct 15, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@topherfangio
Copy link
Contributor

Appears to still be an issue in 1.0.0-rc2: http://codepen.io/topherfangio/pen/EVpeBV

Prioritizing for RC4 (don't think we can get it into RC3).

@topherfangio topherfangio modified the milestones: 1.0-rc4, 1.0-rc3 Nov 3, 2015
topherfangio added a commit that referenced this issue Nov 13, 2015
@topherfangio
fix(list): Copy md-icon.md-secondary attributes to button.
274ef3a 
When an secondary md-icon was used in combination with a
checkbox, the md-icon was only copying the `ng-click` attribute
instead of all attributes including things like `ng-disabled`.

Fix by ensuring we copy all relevant attributes to the wrapper.

Fixes #3356.
@topherfangio topherfangio mentioned this issue Nov 13, 2015
Closed
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@topherfangio topherfangio modified the milestones: 1.0-rc6, 1.0-rc5 Nov 23, 2015
@topherfangio
Copy link
Contributor

This has a PR waiting, but it looks like I need to rebase it before we merge. Will definitely get this merged into RC6.

@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Nov 23, 2015
topherfangio added a commit that referenced this issue Nov 23, 2015
@topherfangio
fix(list): Copy md-icon.md-secondary attributes to button.
5d4d275 
When an secondary md-icon was used in combination with a
checkbox, the md-icon was only copying the `ng-click` attribute
instead of all attributes including things like `ng-disabled`.

Fix by ensuring we copy all relevant attributes to the wrapper.

Fixes #3356.
@ThomasBurleson ThomasBurleson removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0-rc6
Development

No branches or pull requests
4 participants
@topherfangio @ThomasBurleson @shalabhaggarwal @mukilane