This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): Copy md-icon.md-secondary attributes to button. #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
topherfangio
added
needs: work
and removed
pr: merge ready
topherfangio
added
the
in progress
topherfangio
force-pushed
the
team/topher/fix-disabled-list-icon-3356
branch
from
274ef3a
to
5d4d275
Compare
When an secondary md-icon was used in combination with a checkbox, the md-icon was only copying the `ng-click` attribute instead of all attributes including things like `ng-disabled`. Fix by ensuring we copy all relevant attributes to the wrapper. Fixes #3356.
topherfangio
added
pr: merge ready
|
@ThomasBurleson This is has been rebased and is ready for review/merge. |
ThomasBurleson
removed
the
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an secondary md-icon was used in combination with a checkbox, the md-icon was only copying the
ng-clickattribute instead of all attributes including things likeng-disabled.Fix by ensuring we copy all relevant attributes to the wrapper.
Fixes #3356.