Fix stdin usage text in PrintUsage #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torwig
approved these changes
Jul 4, 2023
git-hulk
approved these changes
Jul 4, 2023
tisonkun
reviewed
Jul 4, 2023
| @@ -144,7 +144,7 @@ static void PrintUsage(const char *program) { | |||
| std::cout << program << " implements the Redis protocol based on rocksdb" << std::endl | |||
| << "Usage:" << std::endl | |||
| << std::left << new_opt << "-c, --config <filename>" | |||
| << "set config file to <filename>, or `-' for stdin" << std::endl | |||
There was a problem hiding this comment.
This is actually some old-fashion style back to the age of UNIX commands or POSIX commands manual.
I'm OK with this change but notice here that it's not a "mistake" to fix :D
There was a problem hiding this comment.
kind of interested in this, do you happen to have a link to it? thanks for pointing it out btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.