Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stdin usage text in PrintUsage #1537

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix stdin usage text in PrintUsage #1537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c524cb1
Fix stdin usage text in PrintUsage
enjoy-binbin Jul 4, 2023
5e80d74
Merge branch 'unstable' into fix_help_message
git-hulk Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static void PrintUsage(const char *program) {
std::cout << program << " implements the Redis protocol based on rocksdb" << std::endl
<< "Usage:" << std::endl
<< std::left << new_opt << "-c, --config <filename>"
<< "set config file to <filename>, or `-' for stdin" << std::endl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually some old-fashion style back to the age of UNIX commands or POSIX commands manual.

I'm OK with this change but notice here that it's not a "mistake" to fix :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have never noticed this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of interested in this, do you happen to have a link to it? thanks for pointing it out btw

<< "set config file to <filename>, or `-` for stdin" << std::endl
<< new_opt << "-v, --version"
<< "print version information" << std::endl
<< new_opt << "-h, --help"
Expand Down
Loading