Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1313. Use matrix build for unit tests to reduce CI time #422

Merged
merged 23 commits into from
Mar 12, 2021

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Feb 9, 2021

What changes were proposed in this pull request?

Execute tests in 3 splits to speed up CI feedback a bit. Split are defined via Maven profiles. This reduces time required for unit check to about 10 minutes.

https://issues.apache.org/jira/browse/RATIS-1313

How was this patch tested?

Compared list of tests from Maven output to a previous, single run. Verified that no tests are missed, and each of them is executed only once.

https://github.com/adoroszlai/incubator-ratis/actions/runs/551983793

@adoroszlai adoroszlai marked this pull request as ready for review February 22, 2021 16:17
@adoroszlai adoroszlai changed the title RATIS-1313. Use matrix build for unit tests RATIS-1313. Use matrix build for unit tests to reduce CI time Mar 9, 2021
@adoroszlai
Copy link
Contributor Author

@szetszwo @runzhiwang can someone please review?

@cnauroth
Copy link
Contributor

+1 (non-binding)

That's a really nice improvement. The changes look good. I spot checked CI output for any missing or duplicated test runs, but it all looked good to me. Thanks, @adoroszlai !

@runzhiwang
Copy link
Contributor

runzhiwang commented Mar 12, 2021

+1, LGTM

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo merged commit f0942d0 into apache:master Mar 12, 2021
@adoroszlai adoroszlai deleted the RATIS-1313 branch March 12, 2021 06:49
@adoroszlai
Copy link
Contributor Author

Thanks @cnauroth, @runzhiwang, @szetszwo for the review.

@szetszwo
Copy link
Contributor

Hey @adoroszlai ,
image

Is it the case that if the grpc tests have failed, the server and the misc tests will be cancelled? It seems better to always run all the tests since the overall running time is short. This is the reason that we moved the tests to the ratis-test module; see https://issues.apache.org/jira/browse/RATIS-399

@adoroszlai
Copy link
Contributor Author

Is it the case that if the grpc tests have failed, the server and the misc tests will be cancelled?

Correct. I will post a follow-up change to always run all tests for push and schedule builds, but keep this fail-fast behavior for PRs.

@szetszwo
Copy link
Contributor

That's great. Thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants