-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-1313. Use matrix build for unit tests to reduce CI time #422
Conversation
@szetszwo @runzhiwang can someone please review? |
+1 (non-binding) That's a really nice improvement. The changes look good. I spot checked CI output for any missing or duplicated test runs, but it all looked good to me. Thanks, @adoroszlai ! |
+1, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
Thanks @cnauroth, @runzhiwang, @szetszwo for the review. |
Hey @adoroszlai , Is it the case that if the grpc tests have failed, the server and the misc tests will be cancelled? It seems better to always run all the tests since the overall running time is short. This is the reason that we moved the tests to the ratis-test module; see https://issues.apache.org/jira/browse/RATIS-399 |
Correct. I will post a follow-up change to always run all tests for |
That's great. Thanks for the fast response! |
What changes were proposed in this pull request?
Execute tests in 3 splits to speed up CI feedback a bit. Split are defined via Maven profiles. This reduces time required for unit check to about 10 minutes.
https://issues.apache.org/jira/browse/RATIS-1313
How was this patch tested?
Compared list of tests from Maven output to a previous, single run. Verified that no tests are missed, and each of them is executed only once.
https://github.com/adoroszlai/incubator-ratis/actions/runs/551983793