RATIS-1341. Fail-fast tests only for PRs #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
Mar 18, 2021
|
Thanks @szetszwo for reviewing and committing it. |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#422 added matrix build for unit tests with 3 splits, with fail-fast behavior (if one split fails, other splits are cancelled). @szetszwo pointed out that
I propose to run all tests for
pushbuilds, but keep fail-fast behavior for PRs. The rationale is that PRs should be merged only after fully green build, so any failing test requires a new run.https://issues.apache.org/jira/browse/RATIS-1341
How was this patch tested?
Push build with failed unit (grpc) check, but completed other unit checks:
https://github.com/adoroszlai/incubator-ratis/actions/runs/660949453