fix(generic-x-axis): skip initial time filter for legacy charts (#23506)

(cherry picked from commit 8db5cb1)
apache · May 31, 2023 · 86f79be · 86f79be
1 parent 8f57d90
commit 86f79be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/mixins.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/mixins.tsx
@@ -73,9 +73,11 @@ export const datePickerInAdhocFilterMixin: Pick<
   initialValue: (control: ControlState, state: ControlPanelState | null) => {
     // skip initialValue if
     // 1) GENERIC_CHART_AXES is disabled
-    // 2) there was a time filter in adhoc filters
+    // 2) the time_range control is present (this is the case for legacy charts)
+    // 3) there was a time filter in adhoc filters
     if (
       !hasGenericChartAxes ||
+      state?.controls?.time_range?.value ||
       ensureIsArray(control.value).findIndex(
         (flt: any) => flt?.operator === 'TEMPORAL_RANGE',
       ) > -1

diff --git a/superset-frontend/src/explore/components/ControlPanelsContainer.tsx b/superset-frontend/src/explore/components/ControlPanelsContainer.tsx
@@ -494,7 +494,7 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
       ) => {
         const isTemporalRange = (filter: Record<string, any>) =>
           filter.operator === Operators.TEMPORAL_RANGE;
-        if (isTemporalRange(valueToBeDeleted)) {
+        if (!controls?.time_range?.value && isTemporalRange(valueToBeDeleted)) {
           const count = values.filter(isTemporalRange).length;
           if (count === 1) {
             return t(