fix(generic-x-axis): skip initial time filter for legacy charts #23506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
pushed a commit
that referenced
this pull request
May 23, 2023
(cherry picked from commit 8db5cb1)
eschutho
pushed a commit
that referenced
this pull request
May 25, 2023
(cherry picked from commit 8db5cb1)
eschutho
pushed a commit
that referenced
this pull request
May 31, 2023
(cherry picked from commit 8db5cb1)
mistercrunch
added
🍒 2.1.1
🍒 2.1.2
🍒 2.1.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently legacy charts with the time range control will get time filters doubly applied when
GENERIC_CHART_AXESis enabled. This adds a check to skip conversion of the time range to an adhoc temporal filter if the control is present in the control panel, and also lets the user remove the last temporal filter if the time range control is present.AFTER
Now legacy charts only get time ranges applied once if there are no additional time filters:
BEFORE
Previously legacy charts would automatically add the time range to the adhoc filters control, causing the time range to apply twice:
It was also impossible to remove the last temporal filter in charts that have the time range control:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION