Enhanced counter debouncing #8021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commands CounterDebounceLow and CounterDebounceHigh to allow individual debounce times for low and high pulse widths to discard non valid falling edges. These are checked before legacy CounterDebounce checks distance between to valid falling edges. Useful to have robust counter results when using e.g. an TCRT5000 optical sensor to count electromechanical "Ferraris" electricity meters.
|
What a simple capacitor could have solved... |
arendst
added a commit
that referenced
this pull request
Mar 31, 2020
Add commands ``CounterDebounceLow`` and ``CounterDebounceHigh`` to control debouncing (#8021)
don't forget about the resistor and a 2nd resistor + a diode if you need it asymmetrical ... |
|
Any hints on how these commands are supposed to work? |
|
@to-scho pls provide info to @blakadder |
|
I added further description in PR #236 of the docs |
|
So actually this link :-) tasmota/docs#236 https://tasmota.github.io/docs/Commands/ and look for CounterDebounceLow and CounterDebounceHigh |
What capacitor I can use? Thx. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands CounterDebounceLow and CounterDebounceHigh to allow individual debounce times for low and high pulse widths to discard non valid falling edges. These are checked before legacy CounterDebounce checks distance between to valid falling edges.
Useful to have robust counter results when using e.g. an TCRT5000 optical sensor to count electromechanical "Ferraris" electricity meters.
Description:
Related issue (if applicable): fixes #7488, fixes #516
Checklist: