chore(argo-rollouts): add option to disable creation of notifications configmap #2849
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkool
force-pushed
the
notifications-cm-create-option
branch
from
b700689
to
9daf13e
Compare
rolandkool
force-pushed
the
notifications-cm-create-option
branch
from
9daf13e
to
961247b
Compare
yu-croco
reviewed
Jul 26, 2024
yu-croco
changed the title
… configmap This allows for using the upstream notifications configmap from https://github.com/argoproj/argo-rollouts/blob/master/manifests/notifications-install.yaml Signed-off-by: Roland Kool <rkool@bol.com>
Signed-off-by: Roland Kool <rkool@bol.com>
rolandkool
force-pushed
the
notifications-cm-create-option
branch
from
8fa81ee
to
2c43b9e
Compare
Signed-off-by: Roland Kool <rkool@bol.com>
yu-croco
approved these changes
Jul 27, 2024
mkilchhofer
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for using the upstream notifications configmap from https://github.com/argoproj/argo-rollouts/blob/master/manifests/notifications-install.yaml
Checklist: