fix(argocd-apps): don't render empty app description #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reegnz
requested review from
mkilchhofer,
jmeridth and
yu-croco
as code owners
Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>
reegnz
force-pushed
the
fix_rendering_empty_description
branch
from
7061f3f
to
d7faef4
Compare
mkilchhofer
approved these changes
Sep 4, 2024
yu-croco
previously approved these changes
Sep 4, 2024
|
Hi @reegnz , thank you for your PR. |
mkilchhofer
requested changes
Sep 10, 2024
Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
mkilchhofer
approved these changes
Sep 10, 2024
yu-croco
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering empty description leads to failed validation when using kubeconform.
Signed-off-by: Zoltán Reegn zoltan.reegn@gmail.com
Checklist: