Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argocd-apps): don't render empty app description #2911

Merged
merged 3 commits into from
Sep 10, 2024
+6 −4
Merged

fix(argocd-apps): don't render empty app description #2911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7faef4
fix(argocd-apps): don't render empty app description
reegnz Sep 4, 2024
0b2e000
chore: Apply suggestions from code review
mkilchhofer Sep 10, 2024
66e261a
Merge branch 'main' into fix_rendering_empty_description
mkilchhofer Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/argocd-apps/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: argocd-apps
description: A Helm chart for managing additional Argo CD Applications and Projects
type: application
version: 2.0.0
version: 2.0.1
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
keywords:
Expand All @@ -17,5 +17,5 @@
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: added
description: make the chart use maps instead of lists
- kind: fixed

Check failure on line 20 in charts/argocd-apps/Chart.yaml

View workflow job for this annotation

GitHub Actions / chart-test 

20:18 [trailing-spaces] trailing spaces
mkilchhofer marked this conversation as resolved.
Show resolved Hide resolved
description: not rendering empty app description
4 changes: 3 additions & 1 deletion charts/argocd-apps/templates/projects.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ spec:
{{- with $projectData.permitOnlyProjectScopedClusters }}
permitOnlyProjectScopedClusters: {{ . }}
{{- end }}
description: {{ $projectData.description }}
{{- with $projectData.description }}
description: {{ . }}
{{- end }}
{{- with $projectData.sourceRepos }}
sourceRepos:
{{- toYaml . | nindent 4 }}
Expand Down
Loading