Build packages for Android #647
Conversation
First pass the locations of Python.h and libpython.so in the environment variables CPPFLAGS and LDFLAGS. Then run pip via the androidenv module.
|
Wow - this is awesome... and a lot simpler than I thought it would be - thanks! I'll need to take a closer look (especially into what exactly androidenv is doing), but this looks like a really good start! |
src/briefcase/commands/create.py
Outdated
| # sysconfig.get_config_var("INCLUDEPY") | ||
| includepy = os.path.join( | ||
| self.bundle_path(app), "app", "include", | ||
| "python{}m".format(self.python_version_tag), |
There was a problem hiding this comment.
This path doesn't exist, is the trailing 'm' a mistake?
There was a problem hiding this comment.
The "m" is a suffix added by Python when it is configured with --with-pymalloc. It seems this is only valid for 3.6 and 3.7: https://github.com/beeware/Python-Android-support/blob/master/main.sh#L84 I'll fix this.
src/briefcase/commands/create.py
Outdated
| env.update({"CPPFLAGS": " ".join(cppflags)}) | ||
| # sysconfig.get_config_var("LIBDIR") | ||
| libdir = os.path.join( | ||
| self.bundle_path(app), "app", "libs", "arm64-v8a" |
There was a problem hiding this comment.
Why is it hardcoded for arm64-v8a? It should be compatible with all available targets, as the emulator can run with a x86_64 arch for example.
There was a problem hiding this comment.
Yes, good point. This will require changes to the beeware/Python-Android-support project to include four architecture-specific "app_packages" directories, as well as changes to the beeware/briefcase-android-gradle-template project to add the right directory to sys.path. I'll try to implement this.
Edit: We may be able to avoid architecture-specific directories by having architecture-specific filename extensions. This is set by the variable EXT_SUFFIX in Python's configure script, and available at run-time with sysconfig.get_config_var("EXT_SUFFIX"). Something like ".arm64-v8a.so" maybe. Hmmm it can't be that easy...
mansourmoufid
force-pushed
the
android
branch
from
6151c37
to
6ce88d1
Compare
|
I have been using the SDK from Android Studio, so I didn't notice that ANDROID_SDK_ROOT was not in pip's environment for everyone using the SDK downloaded by briefcase. This latest commit should fix that, hopefully. |
mansourmoufid
force-pushed
the
android
branch
from
f514ad8
to
a42cb81
Compare
|
OK, with the latest commit (f94f62b) and beeware/briefcase-android-gradle-template/pull/44, briefcase builds for every ABI. I only tested this with NumPy, and only on arm64-v8a. Edit: (bee-venv) % find android -name '*.so' |
|
@eliteraspberries I fixed the merge conflict and updated the PR. I would really like to see this merged because you went most of the way to get something working. I think this probably needs:
Is there anything else? How can I help? |
|
@danyeaw There's one big additional requirement: it requires a change to Python's distutils. That's the biggest impediment at present, because there isn't a "simple fix" we can apply - we need a change made upstream in CPython. Alternatively, we need to work out a way for an end user to patch distutils in a way that enables them to leverage those changes. That might mean we need to maintain a forked version of distutils in the short term while we attempt to get this change upstreamed - although I'm open to any other suggestions. |
|
@freakboy3742 Good point. Since distutils as part of the standard library is now deprecated and is being updated / migrated as part of setuptools, maybe this hurdle might not be so high. @eliteraspberries Can androidenv make use of the vendored version of distutils in setuptools if setuptools is installed? I think this is now the default behavior of setuptools as long as it isn't overriden with This change might make the androidenv patch of |
|
I'm going to close this PR; thanks for the work you've put into this, but it looks like we have a path forward using the Chaquopy toolchain as a base for Android projects. |
Is there a timeline, pull request, or issue for this change? We are looking at using BeeWare for a research project because of its small complexity and since it only requires one language. However, Numpy support is a must for us and I think we don't have the skills and resources to add support for binary packages ourselves. I'd love to know how this effort comes along. |
|
The central PR for this change is beeware/briefcase-android-gradle-template#52, and we're aiming to release it by the end of August. Binary packages will initially only be available for Python 3.8, and will include all the packages currently supported by Chaquopy. Later we'll add packages for Python 3.9, 3.10 and possibly 3.7. |
Looking for feedback as this is very experimental. :)
Edit: This is in reference to #471.
PR Checklist: