Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding ranlib on macOS with env var #50

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Sep 5, 2021

Previously opened by mistake in pypa/setuptools#2754

Fixes https://bugs.python.org/issue37916

@isuruf
Copy link
Contributor Author

isuruf commented Sep 16, 2021

Can someone approve for github actions to start?

@isuruf
Copy link
Contributor Author

isuruf commented Sep 16, 2021

Thanks. I pushed again. Needs approval

@isuruf
Copy link
Contributor Author

isuruf commented Sep 16, 2021

Tests pass on github actions in my fork. Ready for review.

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@FFY00 FFY00 merged commit 887749a into pypa:main Sep 16, 2021
@isuruf
Copy link
Contributor Author

isuruf commented Sep 16, 2021

Thanks @FFY00

@isuruf isuruf deleted the ranlib branch September 16, 2021 19:38
jaraco added a commit that referenced this pull request Jul 1, 2023
* Added a config for dependabot.

* Update features list for dependabot.

Co-authored-by: KOLANICH <kolan_n@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants