Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Commit

Permalink
Follow up rewrites regression test for vercel#25208 (vercel#25282)
Browse files Browse the repository at this point in the history
## Summary

Follow up regression test for rewrites with a `has` condition throwing errors in older browsers  vercel#25208.

@timneutkens Let me know if this is what you had in mind? 😸
  • Loading branch information
jamsinclair committed May 20, 2021
1 parent 31b8738 commit bb7f3d3
Show file tree
Hide file tree
Showing 4 changed files with 106 additions and 1 deletion.
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ stages:
path: $(System.DefaultWorkingDirectory)
displayName: Cache Build
- script: |
yarn testie --forceExit test/integration/production/ test/integration/css-client-nav/
yarn testie --forceExit test/integration/production/ test/integration/css-client-nav/ test/integration/rewrites-has-condition/
displayName: 'Run tests'
- job: test_unit
Expand Down
20 changes: 20 additions & 0 deletions test/integration/rewrites-has-condition/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module.exports = {
rewrites() {
return [
{
source: '/rewrite-simple',
destination: '/another',
},
{
source: '/rewrite-with-has',
has: [
{
type: 'query',
key: 'hasQuery',
},
],
destination: '/another',
},
]
},
}
13 changes: 13 additions & 0 deletions test/integration/rewrites-has-condition/pages/another.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { useRouter } from 'next/router'

export default function Page() {
const router = useRouter()

return (
<>
<p id="another">another page</p>
<p id="pathname">{router.pathname}</p>
<p id="query">{JSON.stringify(router.query)}</p>
</>
)
}
72 changes: 72 additions & 0 deletions test/integration/rewrites-has-condition/test/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/* eslint-env jest */

import { join } from 'path'
import {
findPort,
killApp,
launchApp,
nextBuild,
nextStart,
} from 'next-test-utils'
import webdriver from 'next-webdriver'

jest.setTimeout(1000 * 60 * 2)

const appDir = join(__dirname, '../')

let appPort
let app

const runTests = () => {
it('should load page rewrite without browser errors', async () => {
const browser = await webdriver(appPort, '/rewrite-simple')

expect(await browser.waitForElementByCss('#another').text()).toBe(
'another page'
)

const browserLogs = await browser.log('browser')
const errorLogs = browserLogs.filter((log) => {
return log.level.name === 'SEVERE' && log.message.includes('Error:')
})
expect(errorLogs).toEqual([])
})

// Regression test for https://github.com/vercel/next.js/issues/25207
it('should load page rewrite, with "has" condition, without browser errors', async () => {
const browser = await webdriver(appPort, '/rewrite-with-has?hasQuery=123')

expect(await browser.waitForElementByCss('#another').text()).toBe(
'another page'
)

const browserLogs = await browser.log('browser')
const errorLogs = browserLogs.filter((log) => {
return log.level.name === 'SEVERE' && log.message.includes('Error:')
})
expect(errorLogs).toEqual([])
})
}

describe('rewrites has condition', () => {
describe('dev mode', () => {
beforeAll(async () => {
appPort = await findPort()
app = await launchApp(appDir, appPort)
})
afterAll(() => killApp(app))

runTests()
})

describe('production mode', () => {
beforeAll(async () => {
await nextBuild(appDir)
appPort = await findPort()
app = await nextStart(appDir, appPort)
})
afterAll(() => killApp(app))

runTests()
})
})

0 comments on commit bb7f3d3

Please sign in to comment.