Follow up rewrites regression test for #25208 #25282

jamsinclair · 2021-05-20T03:56:16Z

Summary

Follow up regression test for rewrites with a has condition throwing errors in older browsers #25208.

@timneutkens Let me know if this is what you had in mind? 😸

jamsinclair · 2021-05-20T06:23:27Z

Looks to be failing on azure, will debug further.

Edit:
Selenium doesn't support browser logs in IE - SeleniumHQ/selenium#4802. This will make this test redundant as there's no way to assert that an error is being logged. Feel free to close.

timneutkens

Looks good 💯

timneutkens · 2021-05-20T12:02:48Z

Client navigation does not work without the fix right? So asserting if you can navigate to another page would be enough for a test?

ijjk · 2021-05-20T12:14:31Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
buildDuration	14s	14.2s	⚠️ +157ms
buildDurationCached	4.2s	4.3s	⚠️ +110ms
nodeModulesSize	46.7 MB	46.7 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.669	2.626	-0.04
/ avg req/sec	936.62	952.16	+15.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.49	1.498	⚠️ +0.01
/error-in-render avg req/sec	1677.45	1668.88	⚠️ -8.57

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
index.html gzip	559 B	559 B	✓
link.html gzip	567 B	567 B	✓
withRouter.html gzip	555 B	555 B	✓
Overall change	1.68 kB	1.68 kB	✓

Serverless Mode

General

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
buildDuration	16.4s	17.4s	⚠️ +1s
buildDurationCached	5.3s	5.3s	-3ms
nodeModulesSize	46.7 MB	46.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
buildDuration	13.4s	12.9s	-516ms
buildDurationCached	5.3s	5.2s	-77ms
nodeModulesSize	46.7 MB	46.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.741	2.689	-0.05
/ avg req/sec	912.09	929.57	+17.48
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.514	1.567	⚠️ +0.05
/error-in-render avg req/sec	1651.59	1595.89	⚠️ -55.7

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.25 kB	7.25 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.38 kB	9.38 kB	✓

Client Build Manifests

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamsinclair/next.js test/ie11-rewrites-regression	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 3145e13

@timneutkens

## Summary Follow up regression test for rewrites with a `has` condition throwing errors in older browsers vercel#25208. @timneutkens Let me know if this is what you had in mind? 😸

test: add rewrites regression test for vercel#25207

6a2ad90

jamsinclair requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners May 20, 2021 03:56

This comment has been minimized.

Sign in to view

Merge branch 'canary' into test/ie11-rewrites-regression

ac96bcd

This comment has been minimized.

Sign in to view

timneutkens approved these changes May 20, 2021

View reviewed changes

Merge branch 'canary' into test/ie11-rewrites-regression

3145e13

kodiakhq bot merged commit 1f9e958 into vercel:canary May 20, 2021

sync-by-unito bot mentioned this pull request May 26, 2021

chore(deps): bump next from 10.0.7 to 10.2.3 filecoin-project/slate#766

Closed

This was referenced Jul 29, 2021

[Snyk] Upgrade next from 10.0.3 to 10.2.3 bgeveritt-snyk/next.js#9

Open

[Snyk] Upgrade next from 10.0.7 to 10.2.3 bgeveritt-snyk/next.js#21

Open

snyk-bot mentioned this pull request Oct 19, 2021

[Snyk] Upgrade next from 10.0.8 to 10.2.3 orysmudi/next.js#2

Open

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow up rewrites regression test for #25208 #25282

Follow up rewrites regression test for #25208 #25282

jamsinclair commented May 20, 2021

This comment has been minimized.

jamsinclair commented May 20, 2021 •

edited

Loading

This comment has been minimized.

timneutkens left a comment

timneutkens commented May 20, 2021

ijjk commented May 20, 2021

Follow up rewrites regression test for #25208 #25282

Follow up rewrites regression test for #25208 #25282

Conversation

jamsinclair commented May 20, 2021

Summary

This comment has been minimized.

jamsinclair commented May 20, 2021 • edited Loading

This comment has been minimized.

timneutkens left a comment

Choose a reason for hiding this comment

timneutkens commented May 20, 2021

ijjk commented May 20, 2021

Stats from current PR

jamsinclair commented May 20, 2021 •

edited

Loading