This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Fix loading favicons in ChromeImporter #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close for now until the browser-laptop side can accept PNG data from importer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly loads favicon PNG bitmaps regardless of their source (data URL vs. not data URL).
This is not a complete fix for #539 due to what appear to be some bugs in the frontend, specifically
app/importer.js. @darkdh also mentioned that we might not actually want to import all of the PNG data from another browser's profile because it could bloatsession-store-1.