Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Remove Node10 subpath fallbacks #804

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

timostamm
Copy link
Member

Active support for Node.js v10 ended nearly four years ago, security support ended nearly three years ago. I think we can safely remove the fallback for subpath exports in v2.

For context, see #802.

We still maintain the package.json field typesVersions so that TypeScript can see types with Node10 module resolution (it's still commonly used with the alias node). But there doesn't appear to be an obvious reason to maintain JS files for runtime purposes.

Comment on lines +34 to +37
"files": [
"dist/**",
"bin/**"
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to ship our tsconfig.json and src. The result:

$ npm pack -w packages/protoc-gen-es
npm notice 
npm notice 📦  @bufbuild/protoc-gen-es@2.0.0-alpha.1
npm notice === Tarball Contents === 
npm notice 5.0kB  README.md                           
npm notice 174B   bin/protoc-gen-es                   
npm notice 1.0kB  dist/cjs/package.json               
npm notice 14.5kB dist/cjs/src/protoc-gen-es-plugin.js
npm notice 5.5kB  dist/cjs/src/util.js                
npm notice 903B   package.json           
...

@timostamm timostamm merged commit 42087dc into v2 Apr 23, 2024
6 checks passed
@timostamm timostamm deleted the tstamm/remove-node-10-fallback branch April 23, 2024 10:40
@timostamm timostamm mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants