Remove deprecated method delete_row #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavigne958
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Hi thank you for your contribution.
This ticket is planned for the milestone 6.0.0, so I cannot merge this right now for the coming release.
The reason is: any major breaking change should only be introduced with a major version change (like from v5.x.y -> v6.x.y).
We can keep your PR and when we'll work on version 6.0.0 we'll merge it in the master branch 😉
BTW: the request for change is only here to make sure this PR does not merge by mistake in the meantime.
|
Oops! I didn't think about that at all. No worries and thank you for the quick response. |
lavigne958
approved these changes
Jan 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1041
I removed the method, the according test and also run the tests, the format command and the lint command so everything seems to be in order.
I am not sure if I should update the documentation somehow though.