Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method delete_row #1062

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Remove deprecated method delete_row #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions gspread/worksheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,23 +1438,6 @@ def insert_cols(self, values, col=1, value_input_option=ValueInputOption.raw):

return self.spreadsheet.values_append(range_label, params, body)

def delete_row(self, index):
""".. deprecated:: 5.0

Deletes the row from the worksheet at the specified index.

:param int index: Index of a row for deletion.
"""
import warnings

warnings.warn(
"Worksheet.delete_row() is deprecated, "
"Please use `Worksheet.delete_rows()` instead.",
DeprecationWarning,
stacklevel=2,
)
return self.delete_rows(index)

@cast_to_a1_notation
def add_protected_range(
self,
Expand Down
14 changes: 0 additions & 14 deletions tests/worksheet_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,20 +752,6 @@ def test_insert_row(self):
b3 = self.sheet.acell("B3", value_render_option=utils.ValueRenderOption.formula)
self.assertEqual(b3.value, formula)

@pytest.mark.vcr()
def test_delete_row(self):
sg = self._sequence_generator()

for i in range(5):
value_list = [next(sg) for i in range(10)]
self.sheet.append_row(value_list)

prev_row = self.sheet.row_values(1)
next_row = self.sheet.row_values(3)
self.sheet.delete_row(2)
self.assertEqual(self.sheet.row_values(1), prev_row)
self.assertEqual(self.sheet.row_values(2), next_row)

@pytest.mark.vcr()
def test_clear(self):
rows = [
Expand Down